static-metric/Cargo.toml: Remove include section #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releasing static-metric fails with: ``` Caused by: failed to parse manifest at `/xxx/tikv/rust-prometheus/target/package/prometheus-static-metric-0.5.0/Cargo.toml` Caused by: can't find `benches` bench, specify bench.path ``` This is due to the `benches` folder not being included in the final release tarball. With this commit the folder is included and thus releasing prometheus-static-metric would succeed. Signed-off-by: Max Inden <[email protected]>
mxinden
force-pushed
the
static-metric-benches-include
branch
from
e9e7e30 to
19ee1e9
Compare
Member
|
Do we need the Whatever outcome, CI can also validate the fix here with |
This reverts commit 19ee1e9. Signed-off-by: Max Inden <[email protected]>
Signed-off-by: Max Inden <[email protected]>
mxinden
force-pushed
the
static-metric-benches-include
branch
from
d6ccbe4 to
e76706d
Compare
Signed-off-by: Max Inden <[email protected]>
Contributor
Author
|
I followed both suggestions by @lucab. (1) introducing a new check to CI (see failing test on e76706d) and (2) remove the @breeswish as far as I can tell you introduced the |
mxinden
changed the title
lucab
approved these changes
Dec 7, 2020
breezewish
approved these changes
Dec 14, 2020
Contributor
Author
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing static-metric fails with:
This is due to the
benchesfolder not being included in the finalrelease tarball. With this commit the folder is included and thus
releasing prometheus-static-metric would succeed.
Off the top of my head this is the right way to go. Open for alternative
suggestions.